From: Dan Carpenter Date: Sat, 30 Nov 2024 10:07:23 +0000 (+0300) Subject: mailbox: mpfs: fix copy and paste bug in probe X-Git-Tag: v6.14-rc1~97^2~13 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f055feb49c1c4333abb80ce1e9d93841cf74ea84;p=thirdparty%2Fkernel%2Flinux.git mailbox: mpfs: fix copy and paste bug in probe This code accidentally checks ->ctrl_base instead of ->mbox_base so the error handling can never be triggered. Fixes: a4123ffab9ec ("mailbox: mpfs: support new, syscon based, devicetree configuration") Signed-off-by: Dan Carpenter Reviewed-by: Conor Dooley Signed-off-by: Jassi Brar --- diff --git a/drivers/mailbox/mailbox-mpfs.c b/drivers/mailbox/mailbox-mpfs.c index 4df546e3b7eae..d5d9effece979 100644 --- a/drivers/mailbox/mailbox-mpfs.c +++ b/drivers/mailbox/mailbox-mpfs.c @@ -251,7 +251,7 @@ static inline int mpfs_mbox_syscon_probe(struct mpfs_mbox *mbox, struct platform return PTR_ERR(mbox->sysreg_scb); mbox->mbox_base = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(mbox->ctrl_base)) + if (IS_ERR(mbox->mbox_base)) return PTR_ERR(mbox->mbox_base); return 0;