From: Eugenio Pérez <eperezma@redhat.com>
Date: Fri, 15 Sep 2023 17:08:35 +0000 (+0200)
Subject: vdpa net: stop probing if cannot set features
X-Git-Tag: v8.2.0-rc0~88^2~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f1085882d028e5a1b227443cd6e96bbb63d66f43;p=thirdparty%2Fqemu.git

vdpa net: stop probing if cannot set features

Otherwise it continues the CVQ isolation probing.

Fixes: 152128d646 ("vdpa: move CVQ isolation check to net_init_vhost_vdpa")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Message-Id: <20230915170836.3078172-3-eperezma@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---

diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 650125bb0f5..b688877f903 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -1364,6 +1364,7 @@ static int vhost_vdpa_probe_cvq_isolation(int device_fd, uint64_t features,
     r = ioctl(device_fd, VHOST_SET_FEATURES, &features);
     if (unlikely(r)) {
         error_setg_errno(errp, errno, "Cannot set features");
+        goto out;
     }
 
     r = ioctl(device_fd, VHOST_VDPA_SET_STATUS, &status);