From: Liao Yuanhong Date: Wed, 20 Aug 2025 12:40:11 +0000 (+0800) Subject: pds_fwctl: Remove the use of dev_err_probe() X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f12343013022a92fff0cf22cb7b22b9c909cdbf5;p=thirdparty%2Fkernel%2Fstable.git pds_fwctl: Remove the use of dev_err_probe() Logging messages that show some type of "out of memory" error are generally unnecessary as there is a generic message and a stack dump done by the memory subsystem. These messages generally increase kernel size without much added value[1]. The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore, remove the useless call to dev_err_probe(), and just return the value instead. [1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/ Link: https://patch.msgid.link/r/20250820124011.474224-1-liaoyuanhong@vivo.com Signed-off-by: Liao Yuanhong Reviewed-by: Dave Jiang Reviewed-by: Jonathan Cameron Reviewed-by: Brett Creeley Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/fwctl/pds/main.c b/drivers/fwctl/pds/main.c index 9b9d1f6b55566..8dd659aee2563 100644 --- a/drivers/fwctl/pds/main.c +++ b/drivers/fwctl/pds/main.c @@ -481,7 +481,7 @@ static int pdsfc_probe(struct auxiliary_device *adev, pdsfc = fwctl_alloc_device(&padev->vf_pdev->dev, &pdsfc_ops, struct pdsfc_dev, fwctl); if (!pdsfc) - return dev_err_probe(dev, -ENOMEM, "Failed to allocate fwctl device struct\n"); + return -ENOMEM; pdsfc->padev = padev; err = pdsfc_identify(pdsfc);