From: Marc Kleine-Budde Date: Mon, 7 Oct 2019 08:00:52 +0000 (+0200) Subject: can: rx-offload: can_rx_offload_irq_offload_timestamp(): don't use assignment in... X-Git-Tag: v5.5-rc1~174^2~127^2~13 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f1242cd981e36385169281bf7b978e2bfa942eb5;p=thirdparty%2Flinux.git can: rx-offload: can_rx_offload_irq_offload_timestamp(): don't use assignment in if condition This patch moves the assignment of queue_len out of the if condition. Signed-off-by: Marc Kleine-Budde --- diff --git a/drivers/net/can/rx-offload.c b/drivers/net/can/rx-offload.c index c277c51511532..412a8cec5d189 100644 --- a/drivers/net/can/rx-offload.c +++ b/drivers/net/can/rx-offload.c @@ -238,8 +238,8 @@ int can_rx_offload_irq_offload_timestamp(struct can_rx_offload *offload, skb_queue_splice_tail(&skb_queue, &offload->skb_queue); spin_unlock_irqrestore(&offload->skb_queue.lock, flags); - if ((queue_len = skb_queue_len(&offload->skb_queue)) > - (offload->skb_queue_len_max / 8)) + queue_len = skb_queue_len(&offload->skb_queue); + if (queue_len > offload->skb_queue_len_max / 8) netdev_dbg(offload->dev, "%s: queue_len=%d\n", __func__, queue_len);