From: Norbert Pocs <norbertp@openssl.org>
Date: Tue, 8 Jul 2025 08:05:00 +0000 (+0200)
Subject: Address coverity issue 1655294
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f13abf37fd889977d77959c2e4da6f1de7f1d30f;p=thirdparty%2Fopenssl.git

Address coverity issue 1655294

Fixes: https://github.com/openssl/project/issues/1267

Signed-off-by: Norbert Pocs <norbertp@openssl.org>

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27989)
---

diff --git a/crypto/ml_kem/ml_kem.c b/crypto/ml_kem/ml_kem.c
index 7164ead1001..f93ef92ba6c 100644
--- a/crypto/ml_kem/ml_kem.c
+++ b/crypto/ml_kem/ml_kem.c
@@ -1678,6 +1678,8 @@ ML_KEM_KEY *ossl_ml_kem_key_dup(const ML_KEM_KEY *key, int selection)
     void *tmp_pub;
     void *tmp_priv;
 
+    if (key == NULL)
+        return NULL;
     /*
      * Partially decoded keys, not yet imported or loaded, should never be
      * duplicated.
@@ -1685,8 +1687,6 @@ ML_KEM_KEY *ossl_ml_kem_key_dup(const ML_KEM_KEY *key, int selection)
     if (ossl_ml_kem_decoded_key(key))
         return NULL;
 
-    if (key == NULL)
-        return NULL;
     else if ((ret = OPENSSL_memdup(key, sizeof(*key))) == NULL)
         return NULL;