From: Vladimir Sementsov-Ogievskiy Date: Fri, 27 Apr 2018 14:20:01 +0000 (+0300) Subject: nbd/client: fix nbd_negotiate_simple_meta_context X-Git-Tag: v2.12.1~53 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f155487beffb720a8ca7fe88f3b05bea0ddb2a56;p=thirdparty%2Fqemu.git nbd/client: fix nbd_negotiate_simple_meta_context Initialize received variable. Otherwise, is is possible for server to answer without any contexts, but we will set context_id to something random (received_id is not initialized too) and return 1, which is wrong. To solve it, just initialize received to false. Initialize received_id too, just to make all possible checkers happy. Bug was introduced in 78a33ab58782efdb206de14 "nbd: BLOCK_STATUS for standard get_block_status function: client part" with the whole function. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20180427142002.21930-2-vsementsov@virtuozzo.com> Reviewed-by: Eric Blake CC: qemu-stable@nongnu.org Signed-off-by: Eric Blake (cherry picked from commit 89aa0d87634e2cb98517509dc8bdb876f26ecf8b) Signed-off-by: Michael Roth --- diff --git a/nbd/client.c b/nbd/client.c index 3523c863fe5..232ff4f46da 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -619,8 +619,8 @@ static int nbd_negotiate_simple_meta_context(QIOChannel *ioc, { int ret; NBDOptionReply reply; - uint32_t received_id; - bool received; + uint32_t received_id = 0; + bool received = false; uint32_t export_len = strlen(export); uint32_t context_len = strlen(context); uint32_t data_len = sizeof(export_len) + export_len +