From: robertc <>
Date: Sun, 3 Sep 2006 10:15:54 +0000 (+0000)
Subject: (Tres Seaver)Fix bug 975. Ths may cause memory leaks, though running 1000 requests... 
X-Git-Tag: SQUID_3_0_PRE5~126
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f169ddc48b2030b4cddc7f3df7aabd9310be9b01;p=thirdparty%2Fsquid.git

(Tres Seaver)Fix bug 975. Ths may cause memory leaks, though running 1000 requests through showed no sign of it.
---

diff --git a/src/ESIInclude.cc b/src/ESIInclude.cc
index 380fc22c28..a550df6428 100644
--- a/src/ESIInclude.cc
+++ b/src/ESIInclude.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: ESIInclude.cc,v 1.10 2006/09/01 22:19:35 robertc Exp $
+ * $Id: ESIInclude.cc,v 1.11 2006/09/03 04:15:54 robertc Exp $
  *
  * DEBUG: section 86    ESI processing
  * AUTHOR: Robert Collins
@@ -115,7 +115,13 @@ esiBufferRecipient (clientStreamNode *node, ClientHttpRequest *http, HttpReply *
 
 #endif
 
-            delete rep;
+            /* delete rep; 2006/09/02: TS, #975
+             * 
+             * This was causing double-deletes. Its possible that not deleting
+             * it here will cause memory leaks, but if so, this delete should
+             * not be reinstated or it will trigger bug #975 again - RBC
+             * 20060903
+             */
 
             rep = NULL;
         }