From: Vasily Gorbik <gor@linux.ibm.com>
Date: Thu, 8 Apr 2021 22:21:14 +0000 (+0200)
Subject: s390/test_unwind: unify error handling paths
X-Git-Tag: v5.13-rc1~132^2~11
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f169f42130653bd4da24ed0d1b2cc91af5977928;p=thirdparty%2Fkernel%2Flinux.git

s390/test_unwind: unify error handling paths

Handle the case of "unwind state reliable but addr is 0" like other error
cases in this function and trigger output of failing stacktrace to aid
debugging.

Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---

diff --git a/arch/s390/lib/test_unwind.c b/arch/s390/lib/test_unwind.c
index dcd8946255beb..54b36e71ddf30 100644
--- a/arch/s390/lib/test_unwind.c
+++ b/arch/s390/lib/test_unwind.c
@@ -64,8 +64,8 @@ static noinline int test_unwind(struct task_struct *task, struct pt_regs *regs,
 			break;
 		if (state.reliable && !addr) {
 			pr_err("unwind state reliable but addr is 0\n");
-			kfree(bt);
-			return -EINVAL;
+			ret = -EINVAL;
+			break;
 		}
 		sprint_symbol(sym, addr);
 		if (bt_pos < BT_BUF_SIZE) {