From: Ævar Arnfjörð Bjarmason Date: Thu, 23 Sep 2021 16:48:22 +0000 (+0200) Subject: bundle: remove ignored & undocumented "--verbose" flag X-Git-Tag: v2.34.0-rc0~100^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f188160be9e17cba00cc4e0e501c1ab74e88fc80;p=thirdparty%2Fgit.git bundle: remove ignored & undocumented "--verbose" flag In 73c3253d75e (bundle: framework for options before bundle file, 2019-11-10) the "git bundle" command was refactored to use parse_options(). In that refactoring it started understanding the "--verbose" flag before the subcommand, e.g.: git bundle --verbose verify --quiet However, nothing ever did anything with this "verbose" variable, and the change wasn't documented. It appears to have been something that escaped the lab, and wasn't flagged by reviewers at the time. Let's just remove it. Signed-off-by: Ævar Arnfjörð Bjarmason Reviewed-by: Taylor Blau Signed-off-by: Junio C Hamano --- diff --git a/builtin/bundle.c b/builtin/bundle.c index 053a51bea1..5f31354344 100644 --- a/builtin/bundle.c +++ b/builtin/bundle.c @@ -39,8 +39,6 @@ static const char * const builtin_bundle_unbundle_usage[] = { NULL }; -static int verbose; - static int parse_options_cmd_bundle(int argc, const char **argv, const char* prefix, @@ -188,7 +186,6 @@ cleanup: int cmd_bundle(int argc, const char **argv, const char *prefix) { struct option options[] = { - OPT__VERBOSE(&verbose, N_("be verbose; must be placed before a subcommand")), OPT_END() }; int result;