From: Thadeu Lima de Souza Cascardo Date: Tue, 3 Sep 2019 17:18:02 +0000 (-0300) Subject: alarmtimer: Use EOPNOTSUPP instead of ENOTSUPP X-Git-Tag: v5.4-rc1~165^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f18ddc13af981ce3c7b7f26925f099e7c6929aba;p=thirdparty%2Fkernel%2Flinux.git alarmtimer: Use EOPNOTSUPP instead of ENOTSUPP ENOTSUPP is not supposed to be returned to userspace. This was found on an OpenPower machine, where the RTC does not support set_alarm. On that system, a clock_nanosleep(CLOCK_REALTIME_ALARM, ...) results in "524 Unknown error 524" Replace it with EOPNOTSUPP which results in the expected "95 Operation not supported" error. Fixes: 1c6b39ad3f01 (alarmtimers: Return -ENOTSUPP if no RTC device is present) Signed-off-by: Thadeu Lima de Souza Cascardo Signed-off-by: Thomas Gleixner Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/20190903171802.28314-1-cascardo@canonical.com --- diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c index 57518efc38100..b7d75a9e8ccf1 100644 --- a/kernel/time/alarmtimer.c +++ b/kernel/time/alarmtimer.c @@ -672,7 +672,7 @@ static int alarm_timer_create(struct k_itimer *new_timer) enum alarmtimer_type type; if (!alarmtimer_get_rtcdev()) - return -ENOTSUPP; + return -EOPNOTSUPP; if (!capable(CAP_WAKE_ALARM)) return -EPERM; @@ -790,7 +790,7 @@ static int alarm_timer_nsleep(const clockid_t which_clock, int flags, int ret = 0; if (!alarmtimer_get_rtcdev()) - return -ENOTSUPP; + return -EOPNOTSUPP; if (flags & ~TIMER_ABSTIME) return -EINVAL;