From: Alejandro Colomar <alx@kernel.org>
Date: Mon, 11 Dec 2023 12:48:35 +0000 (+0100)
Subject: lib/: Remove /*@out@*/ comments in return type
X-Git-Tag: 4.15.0-rc1~45
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f1b9f8d8291261c53bd5e8fece43d7f3b386a28b;p=thirdparty%2Fshadow.git

lib/: Remove /*@out@*/ comments in return type

/*@out@*/ makes no sense in the return of a function, AFAICS.

Link: <https://splint.org/manual/manual.html#undefined>
Cc: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/list.c b/lib/list.c
index b9c33f769..73c5c4d47 100644
--- a/lib/list.c
+++ b/lib/list.c
@@ -22,7 +22,8 @@
  *	name, and if not present it is added to a freshly allocated
  *	list of users.
  */
-/*@only@*/ /*@out@*/char **add_list (/*@returned@*/ /*@only@*/char **list, const char *member)
+/*@only@*/char **
+add_list(/*@returned@*/ /*@only@*/char **list, const char *member)
 {
 	int i;
 	char **tmp;
@@ -72,7 +73,8 @@
  *	list of users.
  */
 
-/*@only@*/ /*@out@*/char **del_list (/*@returned@*/ /*@only@*/char **list, const char *member)
+/*@only@*/char **
+del_list(/*@returned@*/ /*@only@*/char **list, const char *member)
 {
 	int i, j;
 	char **tmp;
@@ -126,7 +128,8 @@
  * function with list of members, the list elements are not enforced to be
  * constant strings here.
  */
-/*@only@*/ /*@out@*/char **dup_list (char *const *list)
+/*@only@*/char **
+dup_list(char *const *list)
 {
 	int i;
 	char **tmp;
diff --git a/lib/prototypes.h b/lib/prototypes.h
index 5131db535..756bcdd66 100644
--- a/lib/prototypes.h
+++ b/lib/prototypes.h
@@ -214,9 +214,9 @@ extern void setup_limits (const struct passwd *);
 #endif
 
 /* list.c */
-extern /*@only@*/ /*@out@*/char **add_list (/*@returned@*/ /*@only@*/char **, const char *);
-extern /*@only@*/ /*@out@*/char **del_list (/*@returned@*/ /*@only@*/char **, const char *);
-extern /*@only@*/ /*@out@*/char **dup_list (char *const *);
+extern /*@only@*/char **add_list (/*@returned@*/ /*@only@*/char **, const char *);
+extern /*@only@*/char **del_list (/*@returned@*/ /*@only@*/char **, const char *);
+extern /*@only@*/char **dup_list (char *const *);
 extern bool is_on_list (char *const *list, const char *member);
 extern /*@only@*/char **comma_to_list (const char *);