From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 17 Jul 2007 01:22:25 +0000 (+0000)
Subject: Fix outfuncs.c to dump A_Const nodes representing NULLs correctly.  This has
X-Git-Tag: REL7_3_20~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f1dda4c54e1b1d52e9975f9de8feac951ee6d45b;p=thirdparty%2Fpostgresql.git

Fix outfuncs.c to dump A_Const nodes representing NULLs correctly.  This has
been broken since forever, but was not noticed because people seldom look
at raw parse trees.  AFAIK, no impact on users except that debug_print_parse
might fail; but patch it all the way back anyway.  Per report from Jeff Ross.
---

diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
index e1a34118a62..da884a82f74 100644
--- a/src/backend/nodes/outfuncs.c
+++ b/src/backend/nodes/outfuncs.c
@@ -5,7 +5,7 @@
  * Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	$Header: /cvsroot/pgsql/src/backend/nodes/outfuncs.c,v 1.176 2002/10/14 22:14:34 tgl Exp $
+ *	$Header: /cvsroot/pgsql/src/backend/nodes/outfuncs.c,v 1.176.2.1 2007/07/17 01:22:25 tgl Exp $
  *
  * NOTES
  *	  Every (plan) node in POSTGRES has an associated "out" routine which
@@ -1320,6 +1320,10 @@ _outValue(StringInfo str, Value *value)
 			/* internal representation already has leading 'b' */
 			appendStringInfo(str, " %s ", value->val.str);
 			break;
+		case T_Null:
+			/* this is seen only within A_Const, not in transformed trees */
+			appendStringInfo(str, " NULL ");
+			break;
 		default:
 			elog(WARNING, "_outValue: don't know how to print type %d ",
 				 value->type);
@@ -1367,7 +1371,7 @@ _outParamRef(StringInfo str, ParamRef *node)
 static void
 _outAConst(StringInfo str, A_Const *node)
 {
-	appendStringInfo(str, "CONST ");
+	appendStringInfo(str, " A_CONST :val ");
 	_outValue(str, &(node->val));
 	appendStringInfo(str, " :typename ");
 	_outNode(str, node->typename);