From: Wayne Davison <wayned@samba.org>
Date: Tue, 15 Jan 2019 18:38:00 +0000 (-0800)
Subject: Avoid leaving a file open on error return.
X-Git-Tag: v3.2.0pre1~214
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f233dffbd6bf65a08d0d6ce1050eb9c6ed7723cb;p=thirdparty%2Frsync.git

Avoid leaving a file open on error return.
---

diff --git a/util.c b/util.c
index fbbfd8ba..235afa82 100644
--- a/util.c
+++ b/util.c
@@ -342,6 +342,7 @@ int copy_file(const char *source, const char *dest, int ofd, mode_t mode)
 		if (robust_unlink(dest) && errno != ENOENT) {
 			int save_errno = errno;
 			rsyserr(FERROR_XFER, errno, "unlink %s", full_fname(dest));
+			close(ifd);
 			errno = save_errno;
 			return -1;
 		}