From: Christos Tsantilas <chtsanti@users.sourceforge.net>
Date: Mon, 22 Feb 2016 18:01:23 +0000 (+0200)
Subject: author: "William Lima" <william.lima@hscbrasil.com.br>
X-Git-Tag: SQUID_4_0_7~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f235c94b360762c68797b452b4e5023e98d57cff;p=thirdparty%2Fsquid.git

author: "William Lima" <william.lima@hscbrasil.com.br>
Fix memory leak when the cache of sslcrtvalidator_program is disabled via ttl=0
---

diff --git a/src/ssl/helper.cc b/src/ssl/helper.cc
index 741bcef415..224bd4d0fc 100644
--- a/src/ssl/helper.cc
+++ b/src/ssl/helper.cc
@@ -231,7 +231,8 @@ sslCrtvdHandleReplyWrapper(void *data, const ::Helper::Reply &reply)
     if (Ssl::CertValidationHelper::HelperCache &&
             (validationResponse->resultCode == ::Helper::Okay || validationResponse->resultCode == ::Helper::Error)) {
         Ssl::CertValidationResponse::Pointer *item = new Ssl::CertValidationResponse::Pointer(validationResponse);
-        Ssl::CertValidationHelper::HelperCache->add(crtdvdData->query.c_str(), item);
+        if (!Ssl::CertValidationHelper::HelperCache->add(crtdvdData->query.c_str(), item))
+            delete item;
     }
 
     SSL_free(crtdvdData->ssl);