From: Taylor Blau Date: Tue, 14 May 2024 19:57:03 +0000 (-0400) Subject: pack-bitmap-write.c: avoid uninitialized 'write_as' field X-Git-Tag: v2.46.0-rc0~102^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f25e1f2a4d48c6d8bfd659338d4415c7ef4df533;p=thirdparty%2Fgit.git pack-bitmap-write.c: avoid uninitialized 'write_as' field Prepare to free() memory associated with bitmapped_commit structs by zero'ing the 'write_as' field. In ideal cases, it is fine to do something like: for (i = 0; i < writer->selected_nr; i++) { struct bitmapped_commit *bc = &writer->selected[i]; if (bc->write_as != bc->bitmap) ewah_free(bc->write_as); ewah_free(bc->bitmap); } but if not all of the 'write_as' fields were populated (e.g., because the packing_data given does not form a reachability closure), then we may attempt to free uninitialized memory. Guard against this by preemptively zero'ing this field just in case. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano --- diff --git a/pack-bitmap-write.c b/pack-bitmap-write.c index c0087dab12..420f17c2e0 100644 --- a/pack-bitmap-write.c +++ b/pack-bitmap-write.c @@ -112,6 +112,7 @@ static inline void push_bitmapped_commit(struct bitmap_writer *writer, writer->selected[writer->selected_nr].commit = commit; writer->selected[writer->selected_nr].bitmap = NULL; + writer->selected[writer->selected_nr].write_as = NULL; writer->selected[writer->selected_nr].flags = 0; writer->selected_nr++;