From: Darrick J. Wong Date: Wed, 12 Dec 2018 17:42:40 +0000 (-0600) Subject: xfs_scrub: move everything to /usr/sbin X-Git-Tag: v4.20.0-rc1~22 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f26db477ff83136df7e9cb89fec3ea1833e036f9;p=thirdparty%2Fxfsprogs-dev.git xfs_scrub: move everything to /usr/sbin Recently, it was pointed out that xfs_scrub{,_all} depend on components and libraries (libicu, python) that live in /usr. /sbin binaries shouldn't depend on /usr, so let's move the scrub binaries to /usr/sbin. Reported-by: xfs@tlinx.org Signed-off-by: Darrick J. Wong Reviewed-by: Allison Henderson Signed-off-by: Eric Sandeen --- diff --git a/scrub/Makefile b/scrub/Makefile index aebc7e437..c6473c124 100644 --- a/scrub/Makefile +++ b/scrub/Makefile @@ -103,7 +103,7 @@ default: depend $(LTCOMMAND) $(XFS_SCRUB_ALL_PROG) $(OPTIONAL_TARGETS) xfs_scrub_all: xfs_scrub_all.in @echo " [SED] $@" - $(Q)$(SED) -e "s|@sbindir@|$(PKG_ROOT_SBIN_DIR)|g" \ + $(Q)$(SED) -e "s|@sbindir@|$(PKG_SBIN_DIR)|g" \ -e "s|@pkg_version@|$(PKG_VERSION)|g" \ -e "s|@scrub_args@|$(XFS_SCRUB_ARGS)|g" < $< > $@ $(Q)chmod a+x $@ @@ -116,14 +116,14 @@ install: $(INSTALL_SCRUB) %.service: %.service.in @echo " [SED] $@" - $(Q)$(SED) -e "s|@sbindir@|$(PKG_ROOT_SBIN_DIR)|g" \ + $(Q)$(SED) -e "s|@sbindir@|$(PKG_SBIN_DIR)|g" \ -e "s|@scrub_args@|$(XFS_SCRUB_ARGS)|g" \ -e "s|@pkg_lib_dir@|$(PKG_LIB_DIR)|g" \ -e "s|@pkg_name@|$(PKG_NAME)|g" < $< > $@ %.cron: %.cron.in @echo " [SED] $@" - $(Q)$(SED) -e "s|@sbindir@|$(PKG_ROOT_SBIN_DIR)|g" < $< > $@ + $(Q)$(SED) -e "s|@sbindir@|$(PKG_SBIN_DIR)|g" < $< > $@ install-systemd: default $(SYSTEMD_SERVICES) $(INSTALL) -m 755 -d $(SYSTEMD_SYSTEM_UNIT_DIR) @@ -136,9 +136,9 @@ install-crond: default $(CRONTABS) $(INSTALL) -m 644 $(CRONTABS) $(CROND_DIR) install-scrub: default - $(INSTALL) -m 755 -d $(PKG_ROOT_SBIN_DIR) - $(LTINSTALL) -m 755 $(LTCOMMAND) $(PKG_ROOT_SBIN_DIR) - $(INSTALL) -m 755 $(XFS_SCRUB_ALL_PROG) $(PKG_ROOT_SBIN_DIR) + $(INSTALL) -m 755 -d $(PKG_SBIN_DIR) + $(LTINSTALL) -m 755 $(LTCOMMAND) $(PKG_SBIN_DIR) + $(INSTALL) -m 755 $(XFS_SCRUB_ALL_PROG) $(PKG_SBIN_DIR) install-dev: