From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
Date: Wed, 21 Feb 2024 15:17:09 +0000 (+0000)
Subject: src: improve error reporting for destroy command
X-Git-Tag: v1.1.0~94
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f27f032b8da584d4447dc03b3ccd3370433e2c0f;p=thirdparty%2Fnftables.git

src: improve error reporting for destroy command

Example for older kernels (<6.3):
nft destroy table ip missingtable

Before:
Error: Could not process rule: Invalid argument

After:
Error: "destroy" command is not supported, perhaps kernel support is
missing?

Fixes: e1dfd5cc4c46 ("src: add support to command "destroy"")
Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
---

diff --git a/src/cmd.c b/src/cmd.c
index 68c476c6..21533e0e 100644
--- a/src/cmd.c
+++ b/src/cmd.c
@@ -311,6 +311,12 @@ void nft_cmd_error(struct netlink_ctx *ctx, struct cmd *cmd,
 		break;
 	}
 
+	if (cmd->op == CMD_DESTROY && err->err == EINVAL) {
+		netlink_io_error(ctx, loc,
+				 "\"destroy\" command is not supported, perhaps kernel support is missing?");
+		return;
+	}
+
 	netlink_io_error(ctx, loc, "Could not process rule: %s",
 			 strerror(err->err));
 }