From: Valentine Krasnobaeva <vkrasnobaeva@haproxy.com>
Date: Wed, 14 Aug 2024 12:49:51 +0000 (+0200)
Subject: BUG/MINOR: cfgparse-global: remove redundant goto
X-Git-Tag: v3.1-dev6~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f29be97ac7255d85372479323f460aeaba81d7ba;p=thirdparty%2Fhaproxy.git

BUG/MINOR: cfgparse-global: remove redundant goto

In the case, when the given keyword was found in the global 'cfg_kws' list, we
go to 'out' label anyway, after testing rc returned by the keyword's parser. So
there is not a much gain if we perform 'goto out' jump specifically when rc > 0.
---

diff --git a/src/cfgparse-global.c b/src/cfgparse-global.c
index 7908c5d9aa..0e4a7e914e 100644
--- a/src/cfgparse-global.c
+++ b/src/cfgparse-global.c
@@ -1294,7 +1294,6 @@ int cfg_parse_global(const char *file, int linenum, char **args, int kwm)
 					else if (rc > 0) {
 						ha_warning("parsing [%s:%d] : %s\n", file, linenum, errmsg);
 						err_code |= ERR_WARN;
-						goto out;
 					}
 					goto out;
 				}