From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 14 Jun 2005 23:58:00 +0000 (+0000)
Subject: Improve diagnostics for restore_cwd failure.
X-Git-Tag: CPPI-1_12~601
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f2c653e8dfc14a8adaef31947afa7ae084e6cd79;p=thirdparty%2Fcoreutils.git

Improve diagnostics for restore_cwd failure.
---

diff --git a/ChangeLog b/ChangeLog
index a4613110b0..0d9a067ef8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,17 @@
 
 	* Version 5.3.1.
 
+	Improve diagnostics for restore_cwd failure.
+	* src/install.c (main): Standardize on a diagnostic for
+	restore_cwd failure, and report errno.
+	(install_file_in_file_parents): Fail if restore_cwd fails and
+	one of the files is relative.  This fixes a bug (albeit unlikely).
+	* src/mkdir.c (create_parents): Remove static var (now local to 'main').
+	(main): Standardize on a diagnostic for restore_cwd failure,
+	and report errno.
+	Don't bother to check cwd_errno unless create_parents.
+	Use mkdir rather than make_dir; it's simpler.
+
 	* src/install.c (main): Adjust to new make_dir_parents convention.
 	* src/mkdir.c (main): Likewise.
 
diff --git a/lib/ChangeLog b/lib/ChangeLog
index fabf690288..2e0854e914 100644
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,5 +1,13 @@
 2005-06-14  Paul Eggert  <eggert@cs.ucla.edu>
 
+	Improve quality of diagnostics on restore_cwd failure.
+	* mkdir-p.h (make_dir): Remove.  All uses replaced by mkdir.
+	(make_dir_parents): Last arg is now int * (for errno), not bool *.
+	* mkdir-p.c (make_dir, make_dir_parents): Likewise.
+	Rewrite "mkdir -p" algorithm to avoid the need for "stat"
+	each time through the loop.  Do not diagnose restore_cwd failure;
+	that is the caller's job (and perhaps the caller does not care).
+
 	* mkdir-p.c (CLEANUP_CWD, CLEANUP): Remove.
 	(make_dir_parents): Revamp to avoid need for CLEANUP_CWD, CLEANUP.
 	If the file already exists but is not a directory, don't bother