From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Tue, 22 Aug 2017 17:12:43 +0000 (-0400)
Subject: - allow a separate template database to be used for
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f2db99052352d8d87be17628c0e59f225128015a;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- allow a separate template database to be used for
PG CREATE DATABASE.  as nobody will connect to it that would
solve the contention issue here
- backport --nomemory since tox.ini is using it

Change-Id: I00a4d52091876e120faff4a8a5493c53280d96f1
(cherry picked from commit 4c306818396c8cc98a16a14c5ed3361cf6ff373a)
(cherry picked from commit 35e879fcded5b21e70d6de840532187f5d304b46)
---

diff --git a/lib/sqlalchemy/testing/plugin/plugin_base.py b/lib/sqlalchemy/testing/plugin/plugin_base.py
index 2aeebd3192..aeae944fe0 100644
--- a/lib/sqlalchemy/testing/plugin/plugin_base.py
+++ b/lib/sqlalchemy/testing/plugin/plugin_base.py
@@ -65,6 +65,9 @@ def setup_options(make_option):
                 help="Run only tests marked with __backend__")
     make_option("--nomemory", action="store_true", dest="nomemory",
                 help="Don't run memory profiling tests")
+    make_option("--postgresql-templatedb", type="string",
+                help="name of template database to use for Postgresql "
+                     "CREATE DATABASE (defaults to current database)")
     make_option("--low-connections", action="store_true",
                 dest="low_connections",
                 help="Use a low number of distinct connections - "
diff --git a/lib/sqlalchemy/testing/provision.py b/lib/sqlalchemy/testing/provision.py
index 487b610485..52428f5a6f 100644
--- a/lib/sqlalchemy/testing/provision.py
+++ b/lib/sqlalchemy/testing/provision.py
@@ -160,23 +160,26 @@ def _sqlite_post_configure_engine(url, engine, follower_ident):
 
 @_create_db.for_db("postgresql")
 def _pg_create_db(cfg, eng, ident):
+    template_db = cfg.options.postgresql_templatedb
+
     with eng.connect().execution_options(
             isolation_level="AUTOCOMMIT") as conn:
         try:
             _pg_drop_db(cfg, conn, ident)
         except Exception:
             pass
-        currentdb = conn.scalar("select current_database()")
-        for attempt in range(10):
+        if not template_db:
+            template_db = conn.scalar("select current_database()")
+        for attempt in range(3):
             try:
                 conn.execute(
-                    "CREATE DATABASE %s TEMPLATE %s" % (ident, currentdb))
+                    "CREATE DATABASE %s TEMPLATE %s" % (ident, template_db))
             except exc.OperationalError as err:
                 if "accessed by other users" in str(err):
                     log.info(
                         "Waiting to create %s, URI %r, "
-                        "template DB is in use sleeping for .5",
-                        ident, eng.url)
+                        "template DB %s is in use sleeping for .5",
+                        ident, eng.url, template_db)
                     time.sleep(.5)
             else:
                 break