From: Juan Quintela <quintela@redhat.com>
Date: Thu, 4 May 2023 11:38:34 +0000 (+0200)
Subject: migration: qemu_file_total_transferred() function is monotonic
X-Git-Tag: v8.1.0-rc0~143^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f3030d34401ffa1c6dd922eea42225b49b7077c0;p=thirdparty%2Fqemu.git

migration: qemu_file_total_transferred() function is monotonic

So delta_bytes can only be greater or equal to zero.  Never negative.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20230504113841.23130-3-quintela@redhat.com>
---

diff --git a/migration/block.c b/migration/block.c
index 6d532ac7a20..3499f75e37b 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -801,13 +801,7 @@ static int block_save_iterate(QEMUFile *f, void *opaque)
 
     qemu_put_be64(f, BLK_MIG_FLAG_EOS);
     delta_bytes = qemu_file_total_transferred(f) - last_bytes;
-    if (delta_bytes > 0) {
-        return 1;
-    } else if (delta_bytes < 0) {
-        return -1;
-    } else {
-        return 0;
-    }
+    return (delta_bytes > 0);
 }
 
 /* Called with iothread lock taken.  */