From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 25 Oct 2022 16:27:12 +0000 (+0000)
Subject: packages: Make pakfire_package_is_installed private
X-Git-Tag: 0.9.28~216
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f3320724bff133b90f10dae44e26ad7f002a926f;p=pakfire.git

packages: Make pakfire_package_is_installed private

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/_pakfire/package.c b/src/_pakfire/package.c
index 631112958..bd858dcc1 100644
--- a/src/_pakfire/package.c
+++ b/src/_pakfire/package.c
@@ -322,12 +322,6 @@ static void Package_set_filename(PackageObject* self, PyObject* value) {
 	pakfire_package_set_string(self->package, PAKFIRE_PKG_FILENAME, filename);
 }
 
-static PyObject* Package_get_installed(PackageObject* self) {
-	int installed = pakfire_package_is_installed(self->package);
-
-	return PyBool_FromLong(installed);
-}
-
 static PyObject* Package_get_downloadsize(PackageObject* self) {
 	size_t size = pakfire_package_get_downloadsize(self->package);
 
@@ -811,13 +805,6 @@ static struct PyGetSetDef Package_getsetters[] = {
 		NULL,
 		NULL
 	},
-	{
-		"installed",
-		(getter)Package_get_installed,
-		NULL,
-		NULL,
-		NULL
-	},
 	{
 		"downloadsize",
 		(getter)Package_get_downloadsize,
diff --git a/src/libpakfire/include/pakfire/package.h b/src/libpakfire/include/pakfire/package.h
index 9b6aaf4e2..518c70c37 100644
--- a/src/libpakfire/include/pakfire/package.h
+++ b/src/libpakfire/include/pakfire/package.h
@@ -70,7 +70,6 @@ int pakfire_package_set_digest(struct pakfire_package* pkg,
 	enum pakfire_digest_types type, const unsigned char* digest, const size_t length);
 const char* pakfire_package_get_path(struct pakfire_package* pkg);
 void pakfire_package_set_path(struct pakfire_package* pkg, const char* path);
-int pakfire_package_is_installed(struct pakfire_package* pkg);
 size_t pakfire_package_get_downloadsize(struct pakfire_package* pkg);
 void pakfire_package_set_downloadsize(struct pakfire_package* pkg, size_t downloadsize);
 size_t pakfire_package_get_installsize(struct pakfire_package* pkg);
@@ -141,6 +140,8 @@ int pakfire_package_is_source(struct pakfire_package* pkg);
 
 char* pakfire_package_join_evr(const char* e, const char* v, const char* r);
 
+int pakfire_package_is_installed(struct pakfire_package* pkg);
+
 void pakfire_package_add_provides(struct pakfire_package* pkg, const char* dep);
 void pakfire_package_add_prerequires(struct pakfire_package* pkg, const char* dep);
 void pakfire_package_add_requires(struct pakfire_package* pkg, const char* dep);
diff --git a/src/libpakfire/libpakfire.sym b/src/libpakfire/libpakfire.sym
index d457d9462..54ab9480a 100644
--- a/src/libpakfire/libpakfire.sym
+++ b/src/libpakfire/libpakfire.sym
@@ -196,7 +196,6 @@ global:
 	pakfire_package_get_string;
 	pakfire_package_get_suggests;
 	pakfire_package_get_supplements;
-	pakfire_package_is_installed;
 	pakfire_package_ref;
 	pakfire_package_set_build_host;
 	pakfire_package_set_build_id;
diff --git a/src/libpakfire/package.c b/src/libpakfire/package.c
index bd404bdc0..bac0691d9 100644
--- a/src/libpakfire/package.c
+++ b/src/libpakfire/package.c
@@ -647,7 +647,7 @@ PAKFIRE_EXPORT void pakfire_package_set_path(struct pakfire_package* pkg, const
 	pakfire_string_set(pkg->path, path);
 }
 
-PAKFIRE_EXPORT int pakfire_package_is_installed(struct pakfire_package* pkg) {
+int pakfire_package_is_installed(struct pakfire_package* pkg) {
 	Pool* pool = pakfire_get_solv_pool(pkg->pakfire);
 	Solvable* s = get_solvable(pkg);