From: Amin Alaee <mohammadamin.alaee@gmail.com>
Date: Thu, 10 Feb 2022 09:25:00 +0000 (+0100)
Subject: Remove routing decorators in test_gzip.py (#1497)
X-Git-Tag: 0.19.0~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f3403d24048c850062eae6d275dca10f73bb1f4b;p=thirdparty%2Fstarlette.git

Remove routing decorators in test_gzip.py (#1497)
---

diff --git a/tests/middleware/test_gzip.py b/tests/middleware/test_gzip.py
index b917ea4d..a9cedb33 100644
--- a/tests/middleware/test_gzip.py
+++ b/tests/middleware/test_gzip.py
@@ -1,17 +1,19 @@
 from starlette.applications import Starlette
+from starlette.middleware import Middleware
 from starlette.middleware.gzip import GZipMiddleware
 from starlette.responses import PlainTextResponse, StreamingResponse
+from starlette.routing import Route
 
 
 def test_gzip_responses(test_client_factory):
-    app = Starlette()
-
-    app.add_middleware(GZipMiddleware)
-
-    @app.route("/")
     def homepage(request):
         return PlainTextResponse("x" * 4000, status_code=200)
 
+    app = Starlette(
+        routes=[Route("/", endpoint=homepage)],
+        middleware=[Middleware(GZipMiddleware)],
+    )
+
     client = test_client_factory(app)
     response = client.get("/", headers={"accept-encoding": "gzip"})
     assert response.status_code == 200
@@ -21,14 +23,14 @@ def test_gzip_responses(test_client_factory):
 
 
 def test_gzip_not_in_accept_encoding(test_client_factory):
-    app = Starlette()
-
-    app.add_middleware(GZipMiddleware)
-
-    @app.route("/")
     def homepage(request):
         return PlainTextResponse("x" * 4000, status_code=200)
 
+    app = Starlette(
+        routes=[Route("/", endpoint=homepage)],
+        middleware=[Middleware(GZipMiddleware)],
+    )
+
     client = test_client_factory(app)
     response = client.get("/", headers={"accept-encoding": "identity"})
     assert response.status_code == 200
@@ -38,14 +40,14 @@ def test_gzip_not_in_accept_encoding(test_client_factory):
 
 
 def test_gzip_ignored_for_small_responses(test_client_factory):
-    app = Starlette()
-
-    app.add_middleware(GZipMiddleware)
-
-    @app.route("/")
     def homepage(request):
         return PlainTextResponse("OK", status_code=200)
 
+    app = Starlette(
+        routes=[Route("/", endpoint=homepage)],
+        middleware=[Middleware(GZipMiddleware)],
+    )
+
     client = test_client_factory(app)
     response = client.get("/", headers={"accept-encoding": "gzip"})
     assert response.status_code == 200
@@ -55,11 +57,6 @@ def test_gzip_ignored_for_small_responses(test_client_factory):
 
 
 def test_gzip_streaming_response(test_client_factory):
-    app = Starlette()
-
-    app.add_middleware(GZipMiddleware)
-
-    @app.route("/")
     def homepage(request):
         async def generator(bytes, count):
             for index in range(count):
@@ -68,6 +65,11 @@ def test_gzip_streaming_response(test_client_factory):
         streaming = generator(bytes=b"x" * 400, count=10)
         return StreamingResponse(streaming, status_code=200)
 
+    app = Starlette(
+        routes=[Route("/", endpoint=homepage)],
+        middleware=[Middleware(GZipMiddleware)],
+    )
+
     client = test_client_factory(app)
     response = client.get("/", headers={"accept-encoding": "gzip"})
     assert response.status_code == 200