From: Jeff King Date: Fri, 7 Jul 2017 09:07:34 +0000 (-0400) Subject: log: do not free parents when walking reflog X-Git-Tag: v2.14.2~59^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f35650dff6a4;p=thirdparty%2Fgit.git log: do not free parents when walking reflog When we're doing a reflog walk (instead of walking the actual parent pointers), we may see commits multiple times. For this reason, we hold on to the commit buffer for each commit rather than freeing it after we've showed the commit. We should do the same for the parent list. Right now this is just a minor optimization. But once we refactor how reflog walks are performed, keeping the parents will avoid confusing us the second time we see the commit. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/builtin/log.c b/builtin/log.c index cf303b2c06..630d6cff2f 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -377,9 +377,9 @@ static int cmd_log_walk(struct rev_info *rev) * walking the reflogs. */ free_commit_buffer(commit); + free_commit_list(commit->parents); + commit->parents = NULL; } - free_commit_list(commit->parents); - commit->parents = NULL; if (saved_nrl < rev->diffopt.needed_rename_limit) saved_nrl = rev->diffopt.needed_rename_limit; if (rev->diffopt.degraded_cc_to_c)