From: Mike Christie Date: Tue, 17 May 2022 18:08:49 +0000 (-0500) Subject: vhost-test: drop flush after vhost_dev_cleanup X-Git-Tag: v5.19-rc1~54^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f3a1aad9a448e40d4833913cbd50aeec538a74fe;p=thirdparty%2Fkernel%2Flinux.git vhost-test: drop flush after vhost_dev_cleanup The flush after vhost_dev_cleanup is not needed because: 1. It doesn't do anything. vhost_dev_cleanup will stop the worker thread so the flush call will just return since the worker has not device. 2. It's not needed. The comment about jobs re-queueing themselves does not look correct because handle_vq does not requeue work. Signed-off-by: Mike Christie Acked-by: Jason Wang Message-Id: <20220517180850.198915-8-michael.christie@oracle.com> Signed-off-by: Michael S. Tsirkin --- diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c index de39151366c5c..6c139f18bc54e 100644 --- a/drivers/vhost/test.c +++ b/drivers/vhost/test.c @@ -158,9 +158,6 @@ static int vhost_test_release(struct inode *inode, struct file *f) vhost_test_flush(n); vhost_dev_stop(&n->dev); vhost_dev_cleanup(&n->dev); - /* We do an extra flush before freeing memory, - * since jobs can re-queue themselves. */ - vhost_test_flush(n); kfree(n->dev.vqs); kfree(n); return 0;