From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sun, 17 Apr 2016 11:49:54 +0000 (+1200)
Subject: Prevent %O use by deny_info leading to header smuggling
X-Git-Tag: SQUID_4_0_9~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f3bd9c5e9f099bac9b6cfc82e2e1066383ae971a;p=thirdparty%2Fsquid.git

Prevent %O use by deny_info leading to header smuggling
---

diff --git a/src/errorpage.cc b/src/errorpage.cc
index bf09a01300..200af2a30e 100644
--- a/src/errorpage.cc
+++ b/src/errorpage.cc
@@ -928,7 +928,8 @@ ErrorState::Convert(char token, bool building_deny_info_url, bool allowRecursion
         break;
 
     case 'O':
-        do_quote = 0;
+        if (!building_deny_info_url)
+            do_quote = 0;
     case 'o':
         p = request ? request->extacl_message.termedBuf() : external_acl_message;
         if (!p && !building_deny_info_url)