From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Tue, 2 Oct 2018 15:00:29 +0000 (-0700)
Subject: 4.4-stable patches
X-Git-Tag: v4.18.12~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f3dd914455526b85fcf482a244ad39aa20f60fcc;p=thirdparty%2Fkernel%2Fstable-queue.git

4.4-stable patches

added patches:
	arm64-kvm-sanitize-pstate.m-when-being-set-from-userspace.patch
---

diff --git a/queue-4.4/arm64-kvm-sanitize-pstate.m-when-being-set-from-userspace.patch b/queue-4.4/arm64-kvm-sanitize-pstate.m-when-being-set-from-userspace.patch
new file mode 100644
index 00000000000..c38176d3c0e
--- /dev/null
+++ b/queue-4.4/arm64-kvm-sanitize-pstate.m-when-being-set-from-userspace.patch
@@ -0,0 +1,56 @@
+From 2a3f93459d689d990b3ecfbe782fec89b97d3279 Mon Sep 17 00:00:00 2001
+From: Marc Zyngier <marc.zyngier@arm.com>
+Date: Thu, 27 Sep 2018 16:53:22 +0100
+Subject: arm64: KVM: Sanitize PSTATE.M when being set from userspace
+
+From: Marc Zyngier <marc.zyngier@arm.com>
+
+commit 2a3f93459d689d990b3ecfbe782fec89b97d3279 upstream.
+
+Not all execution modes are valid for a guest, and some of them
+depend on what the HW actually supports. Let's verify that what
+userspace provides is compatible with both the VM settings and
+the HW capabilities.
+
+Cc: <stable@vger.kernel.org>
+Fixes: 0d854a60b1d7 ("arm64: KVM: enable initialization of a 32bit vcpu")
+Reviewed-by: Christoffer Dall <christoffer.dall@arm.com>
+Reviewed-by: Mark Rutland <mark.rutland@arm.com>
+Reviewed-by: Dave Martin <Dave.Martin@arm.com>
+Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
+Signed-off-by: Will Deacon <will.deacon@arm.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ arch/arm64/kvm/guest.c |   10 +++++++++-
+ 1 file changed, 9 insertions(+), 1 deletion(-)
+
+--- a/arch/arm64/kvm/guest.c
++++ b/arch/arm64/kvm/guest.c
+@@ -143,17 +143,25 @@ static int set_core_reg(struct kvm_vcpu
+ 	}
+ 
+ 	if (off == KVM_REG_ARM_CORE_REG(regs.pstate)) {
+-		u32 mode = (*(u32 *)valp) & COMPAT_PSR_MODE_MASK;
++		u64 mode = (*(u64 *)valp) & COMPAT_PSR_MODE_MASK;
+ 		switch (mode) {
+ 		case COMPAT_PSR_MODE_USR:
++			if (!system_supports_32bit_el0())
++				return -EINVAL;
++			break;
+ 		case COMPAT_PSR_MODE_FIQ:
+ 		case COMPAT_PSR_MODE_IRQ:
+ 		case COMPAT_PSR_MODE_SVC:
+ 		case COMPAT_PSR_MODE_ABT:
+ 		case COMPAT_PSR_MODE_UND:
++			if (!vcpu_el1_is_32bit(vcpu))
++				return -EINVAL;
++			break;
+ 		case PSR_MODE_EL0t:
+ 		case PSR_MODE_EL1t:
+ 		case PSR_MODE_EL1h:
++			if (vcpu_el1_is_32bit(vcpu))
++				return -EINVAL;
+ 			break;
+ 		default:
+ 			err = -EINVAL;
diff --git a/queue-4.4/series b/queue-4.4/series
index 8ab3095b913..b9699645e15 100644
--- a/queue-4.4/series
+++ b/queue-4.4/series
@@ -68,3 +68,4 @@ e1000-ensure-to-free-old-tx-rx-rings-in-set_ringparam.patch
 hwmon-ina2xx-fix-sysfs-shunt-resistor-read-access.patch
 hwmon-adt7475-make-adt7475_read_word-return-errors.patch
 i2c-i801-allow-acpi-aml-access-i-o-ports-not-reserved-for-smbus.patch
+arm64-kvm-sanitize-pstate.m-when-being-set-from-userspace.patch