From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Thu, 21 Apr 2022 13:41:34 +0000 (+0200)
Subject: BUG/MINOR: mux-quic: unsubscribe on release
X-Git-Tag: v2.6-dev7~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f3e03a40667c1dfadb29621888d0420b50a3b6d2;p=thirdparty%2Fhaproxy.git

BUG/MINOR: mux-quic: unsubscribe on release

Unsubscribe from lower layer on qc_release. This ensures that the lower
layer won't wake up a null tasklet after the MUX has been released and
may prevent a crash.
---

diff --git a/src/mux_quic.c b/src/mux_quic.c
index 6a65d6923b..31ef6d5560 100644
--- a/src/mux_quic.c
+++ b/src/mux_quic.c
@@ -518,6 +518,11 @@ static void qc_release(struct qcc *qcc)
 
 	if (qcc->wait_event.tasklet)
 		tasklet_free(qcc->wait_event.tasklet);
+	if (conn && qcc->wait_event.events) {
+		conn->xprt->unsubscribe(conn, conn->xprt_ctx,
+		                        qcc->wait_event.events,
+		                        &qcc->wait_event);
+	}
 
 	/* liberate remaining qcs instances */
 	node = eb64_first(&qcc->streams_by_id);