From: Björn Baumbach <bb@sernet.de>
Date: Wed, 26 Feb 2020 12:56:14 +0000 (+0100)
Subject: samba-tool group edit: use binary encoded group name
X-Git-Tag: ldb-2.2.0~1550
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f3e7ea0405d46ddfbeba9b3a84c13b7878464180;p=thirdparty%2Fsamba.git

samba-tool group edit: use binary encoded group name

Allows to edit groups with names like e.g. 'group1 (xy)'.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14296

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/netcmd/group.py b/python/samba/netcmd/group.py
index c063657a5ae..76705100960 100644
--- a/python/samba/netcmd/group.py
+++ b/python/samba/netcmd/group.py
@@ -873,7 +873,8 @@ class cmd_group_edit(Command):
         samdb = SamDB(url=H, session_info=system_session(),
                       credentials=creds, lp=lp)
 
-        filter = ("(&(sAMAccountName=%s)(objectClass=group))" % groupname)
+        filter = ("(&(sAMAccountName=%s)(objectClass=group))" %
+                  ldb.binary_encode(groupname))
 
         domaindn = samdb.domain_dn()