From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Fri, 13 Sep 2024 14:35:11 +0000 (+0300)
Subject: dmaengine: ep93xx: Fix a NULL vs IS_ERR() check in probe()
X-Git-Tag: v6.12-rc1~34^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f3eeba0645dcb48c90f64ae6193148bf881429a8;p=thirdparty%2Fkernel%2Flinux.git

dmaengine: ep93xx: Fix a NULL vs IS_ERR() check in probe()

This was intended to be an IS_ERR() check, not a NULL check.  The
ep93xx_dma_of_probe() function doesn't return NULL pointers.

Fixes: 4e8ad5ed845b ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---

diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index 43c4241af7f5f..7de04e8ace442 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -1504,7 +1504,7 @@ static int ep93xx_dma_probe(struct platform_device *pdev)
 	int ret;
 
 	edma = ep93xx_dma_of_probe(pdev);
-	if (!edma)
+	if (IS_ERR(edma))
 		return PTR_ERR(edma);
 
 	dma_dev = &edma->dma_dev;