From: Kuan-Wei Chiu Date: Mon, 27 May 2024 20:30:09 +0000 (+0800) Subject: lib/sort: fix outdated comment regarding glibc qsort() X-Git-Tag: v6.11-rc1~84^2~67 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f49ac9571b8f1de4dfcce941a936a4d19dd7bb8a;p=thirdparty%2Fkernel%2Flinux.git lib/sort: fix outdated comment regarding glibc qsort() The existing comment in lib/sort refers to glibc qsort() using quicksort. However, glibc qsort() no longer uses quicksort; it now uses mergesort and falls back to heapsort if memory allocation for mergesort fails. This makes the comment outdated and incorrect. Update the comment to refer to quicksort in general rather than glibc's implementation to provide accurate information about the comparisons and trade-offs without implying an outdated implementation. Link: https://lkml.kernel.org/r/20240527203011.1644280-3-visitorckw@gmail.com Signed-off-by: Kuan-Wei Chiu Cc: Ching-Chun (Jim) Huang Signed-off-by: Andrew Morton --- diff --git a/lib/sort.c b/lib/sort.c index 651b73205f6d2..b918ae15302da 100644 --- a/lib/sort.c +++ b/lib/sort.c @@ -5,7 +5,7 @@ * This performs n*log2(n) + 0.37*n + o(n) comparisons on average, * and 1.5*n*log2(n) + O(n) in the (very contrived) worst case. * - * Glibc qsort() manages n*log2(n) - 1.26*n for random inputs (1.63*n + * Quicksort manages n*log2(n) - 1.26*n for random inputs (1.63*n * better) at the expense of stack usage and much larger code to avoid * quicksort's O(n^2) worst case. */