From: Lu Baolu <baolu.lu@linux.intel.com>
Date: Wed, 12 Jun 2019 00:28:45 +0000 (+0800)
Subject: iommu/vt-d: Don't return error when device gets right domain
X-Git-Tag: v5.3-rc1~172^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f4c63ea91c6f6d9a1a3062071ff6cc4910ebb8a9;p=thirdparty%2Fkernel%2Flinux.git

iommu/vt-d: Don't return error when device gets right domain

If a device gets a right domain in add_device ops, it shouldn't
return error.

Fixes: 942067f1b6b97 ("iommu/vt-d: Identify default domains replaced with private")
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 10bdf7ea9564b..60ec58bf67011 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -5388,10 +5388,7 @@ static int intel_iommu_add_device(struct device *dev)
 				domain_add_dev_info(si_domain, dev);
 				dev_info(dev,
 					 "Device uses a private identity domain.\n");
-				return 0;
 			}
-
-			return -ENODEV;
 		}
 	} else {
 		if (device_def_domain_type(dev) == IOMMU_DOMAIN_DMA) {
@@ -5406,10 +5403,7 @@ static int intel_iommu_add_device(struct device *dev)
 
 				dev_info(dev,
 					 "Device uses a private dma domain.\n");
-				return 0;
 			}
-
-			return -ENODEV;
 		}
 	}