From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Fri, 8 Oct 2021 12:53:21 +0000 (+0300)
Subject: lib-storage: mail_storage_service_lookup() - Fix memory leak when returning -2
X-Git-Tag: 2.3.18~206
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f4da884f67c5dc9c1a27e8f66bb159436597d68b;p=thirdparty%2Fdovecot%2Fcore.git

lib-storage: mail_storage_service_lookup() - Fix memory leak when returning -2

This was also visible as event leaks.
---

diff --git a/src/lib-storage/mail-storage-service.c b/src/lib-storage/mail-storage-service.c
index 1cc014fe56..567ecb8bc3 100644
--- a/src/lib-storage/mail-storage-service.c
+++ b/src/lib-storage/mail-storage-service.c
@@ -1384,6 +1384,8 @@ mail_storage_service_lookup_real(struct mail_storage_service_ctx *ctx,
 		(void)settings_parse_line(user->set_parser, "mail_plugins=");
 	}
 
+	if (ret < 0)
+		mail_storage_service_user_unref(&user);
 	*user_r = user;
 	return ret;
 }