From: Jeff Layton Date: Thu, 26 Jun 2025 12:52:14 +0000 (-0400) Subject: ref_tracker: do xarray and workqueue job initializations earlier X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f4e6aefb9c6d8f9a5baa2a26bddaff4fbb4d280e;p=thirdparty%2Fkernel%2Flinux.git ref_tracker: do xarray and workqueue job initializations earlier The kernel test robot reported an oops that occurred when attempting to deregister a dentry from the xarray during subsys_initcall(). The ref_tracker xarrays and workqueue job are being initialized in late_initcall() which is too late. Move those to postcore_initcall() instead. Fixes: 65b584f53611 ("ref_tracker: automatically register a file in debugfs for a ref_tracker_dir") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202506251406.c28f2adb-lkp@intel.com Signed-off-by: Jeff Layton Signed-off-by: Jakub Kicinski Link: https://patch.msgid.link/20250626-reftrack-dbgfs-v1-1-812102e2a394@kernel.org --- diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c index dcf923a1edf5b..a9e6ffcff04b1 100644 --- a/lib/ref_tracker.c +++ b/lib/ref_tracker.c @@ -516,13 +516,19 @@ static void debugfs_reap_work(struct work_struct *work) } while (reaped); } -static int __init ref_tracker_debugfs_init(void) +static int __init ref_tracker_debugfs_postcore_init(void) { INIT_WORK(&debugfs_reap_worker, debugfs_reap_work); xa_init_flags(&debugfs_dentries, XA_FLAGS_LOCK_IRQ); xa_init_flags(&debugfs_symlinks, XA_FLAGS_LOCK_IRQ); + return 0; +} +postcore_initcall(ref_tracker_debugfs_postcore_init); + +static int __init ref_tracker_debugfs_late_init(void) +{ ref_tracker_debug_dir = debugfs_create_dir("ref_tracker", NULL); return 0; } -late_initcall(ref_tracker_debugfs_init); +late_initcall(ref_tracker_debugfs_late_init); #endif /* CONFIG_DEBUG_FS */