From: Yu Watanabe Date: Tue, 22 Nov 2022 04:03:55 +0000 (+0900) Subject: network: drop REMOVING flag when a netlink message is sent to kernel X-Git-Tag: v253-rc1~359 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f4ee7b98c434bc9a0f436c29fd32225acd73e183;p=thirdparty%2Fsystemd.git network: drop REMOVING flag when a netlink message is sent to kernel When an interface goes to down, the kernel drops several routes automatically, and at the same time networkd requests to remove them, but the kernel sometimes does not respond the requests. Hence, the routes cannot drop the REMOVING flag, and networkd will never try to configure other routes which depend on the previously removed routes even if they are already reconfigured. With this patch, when networkd sends a request to configure a route (or any other network settings), REMOVING flag for the route is dropped without waiting for the reply about the previous remove request, as we can expect it will appear even if it is already removed or under removing. Fixes #24999. --- diff --git a/src/network/networkd-util.h b/src/network/networkd-util.h index 31ff4bc4256..f75fb1f8685 100644 --- a/src/network/networkd-util.h +++ b/src/network/networkd-util.h @@ -97,7 +97,8 @@ int network_config_state_to_string_alloc(NetworkConfigState s, char **ret); static inline void name##_enter_configuring(type *t) { \ name##_update_state(t, \ NETWORK_CONFIG_STATE_REQUESTING | \ - NETWORK_CONFIG_STATE_CONFIGURING, \ + NETWORK_CONFIG_STATE_CONFIGURING | \ + NETWORK_CONFIG_STATE_REMOVING, \ NETWORK_CONFIG_STATE_CONFIGURING); \ } \ static inline void name##_enter_configured(type *t) { \