From: Anton Johansson <anjo@rev.ng>
Date: Thu, 13 Jul 2023 12:08:53 +0000 (+0200)
Subject: target/hexagon/idef-parser: Remove self-assignment
X-Git-Tag: v9.1.0-rc1~1^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f51e30ff353c5c16ce9d68fe4072a89e7b19b454;p=thirdparty%2Fqemu.git

target/hexagon/idef-parser: Remove self-assignment

The self assignment is clearly useless, and @1.last_column does not have
to be set for an expression with only a single token, so remove it.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Brian Cain <bcain@quicinc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230713120853.27023-1-anjo@rev.ng>
Signed-off-by: Brian Cain <bcain@quicinc.com>
---

diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef-parser/idef-parser.y
index 9ffb9f9699e..c6f17c6afa7 100644
--- a/target/hexagon/idef-parser/idef-parser.y
+++ b/target/hexagon/idef-parser/idef-parser.y
@@ -800,7 +800,6 @@ rvalue : FAIL
 
 lvalue : FAIL
          {
-             @1.last_column = @1.last_column;
              yyassert(c, &@1, false, "Encountered a FAIL token as lvalue.\n");
          }
        | REG