From: Tobias Brunner Date: Mon, 18 Apr 2011 14:10:36 +0000 (+0200) Subject: Properly copy interface name if unknown. X-Git-Tag: 4.5.2~100 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f526b35c455f39aad1fce80894459d9fe3d48e98;p=thirdparty%2Fstrongswan.git Properly copy interface name if unknown. We use a static string if the interface name is unknown, so using memcpy with IFNAMSIZ is incorrect as that would overrun the static string. --- diff --git a/src/libhydra/plugins/kernel_netlink/kernel_netlink_net.c b/src/libhydra/plugins/kernel_netlink/kernel_netlink_net.c index 6d0a567809..8315ed3109 100644 --- a/src/libhydra/plugins/kernel_netlink/kernel_netlink_net.c +++ b/src/libhydra/plugins/kernel_netlink/kernel_netlink_net.c @@ -350,7 +350,7 @@ static void process_link(private_kernel_netlink_net_t *this, entry->addrs = linked_list_create(); this->ifaces->insert_last(this->ifaces, entry); } - memcpy(entry->ifname, name, IFNAMSIZ); + strncpy(entry->ifname, name, IFNAMSIZ); entry->ifname[IFNAMSIZ-1] = '\0'; if (event) {