From: Andrew Burgess <aburgess@redhat.com>
Date: Fri, 15 Dec 2023 13:03:26 +0000 (+0000)
Subject: gdb/testsuite: add some xfail in gdb.base/startup-with-shell.exp
X-Git-Tag: gdb-16-branchpoint~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f56707caa021dbe9a6e68aaa2dd0b13ba01f53df;p=thirdparty%2Fbinutils-gdb.git

gdb/testsuite: add some xfail in gdb.base/startup-with-shell.exp

There are two tests that fail in gdb.base/startup-with-shell.exp when
using the native-extended-remote board.  I plan to fix these issues,
and I've posted a series that does just that:

  https://inbox.sourceware.org/gdb-patches/cover.1730731085.git.aburgess@redhat.com

But until that series is reviewed, I thought I'd merge this commit,
which marks the FAIL as XFAIL and links them to the relevant bug
number.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28392

Tested-By: Guinevere Larsen <guinevere@redhat.com>
---

diff --git a/gdb/testsuite/gdb.base/startup-with-shell.exp b/gdb/testsuite/gdb.base/startup-with-shell.exp
index 670fab6a543..87a755904f6 100644
--- a/gdb/testsuite/gdb.base/startup-with-shell.exp
+++ b/gdb/testsuite/gdb.base/startup-with-shell.exp
@@ -55,11 +55,17 @@ proc initial_setup_simple { startup_with_shell run_args } {
     }
 }
 
+# Are we using 'remote' or 'extended-remote' protocol?
+set is_remote_p [gdb_protocol_is_remote]
+
 ## Run the actual tests
 
 with_test_prefix "startup_with_shell = on; run_args = *.unique-extension" {
     initial_setup_simple "on" "$unique_file_dir/*.unique-extension"
     gdb_test_no_output "set print characters unlimited"
+    if { $is_remote_p } {
+	setup_xfail "*-*-*" gdb/28392
+    }
     gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"$unique_file\"" \
 	"first argument expanded"
 }
@@ -74,6 +80,9 @@ with_test_prefix "startup_with_shell = off; run_args = *.unique-extension" {
 with_test_prefix "startup_with_shell = on; run_args = \$TEST" {
     set env(TEST) "1234"
     initial_setup_simple "on" "\$TEST"
+    if { $is_remote_p } {
+	setup_xfail "*-*-*" gdb/28392
+    }
     gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"1234\"" \
 	"testing first argument"
     unset env(TEST)