From: Jeff King Date: Thu, 24 Sep 2015 21:06:46 +0000 (-0400) Subject: stop_progress_msg: convert sprintf to xsnprintf X-Git-Tag: v2.7.0-rc0~87^2~51 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f5691aa640ae2c1c5f85037e093de7f310c0eac7;p=thirdparty%2Fgit.git stop_progress_msg: convert sprintf to xsnprintf The usual arguments for using xsnprintf over sprintf apply, but this case is a little tricky. We print to a fixed-size buffer if we have room, and otherwise to an allocated buffer. So there should be no overflow here, but it is still good to communicate our intention, as well as to check our earlier math for how much space the string will need. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/progress.c b/progress.c index a3efcfd34c..353bd37416 100644 --- a/progress.c +++ b/progress.c @@ -254,7 +254,7 @@ void stop_progress_msg(struct progress **p_progress, const char *msg) throughput_string(&tp->display, tp->curr_total, rate); } progress_update = 1; - sprintf(bufp, ", %s.\n", msg); + xsnprintf(bufp, len + 1, ", %s.\n", msg); display(progress, progress->last_value, bufp); if (buf != bufp) free(bufp);