From: Lorenzo Bianconi Date: Tue, 4 Jun 2019 22:12:20 +0000 (+0200) Subject: mt76: mt7615: remove key check in mt7615_mcu_set_wtbl_key X-Git-Tag: v5.3-rc1~140^2~52^2~2^2~17 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f57d8fa7fbcc26831b9aea8501aff9986089665f;p=thirdparty%2Fkernel%2Flinux.git mt76: mt7615: remove key check in mt7615_mcu_set_wtbl_key Do not check key pointer in mt7615_mcu_set_wtbl_key since if set_key_cmd is SET_KEY, key will be always not NULL. This patch will address a false positive reported by Coverity-Scan Addresses-Coverity-ID: 1445463 ("Dereference after null check") Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau --- diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c index f2f6b77666f82..76431d00a8ac0 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c @@ -879,7 +879,7 @@ int mt7615_mcu_set_wtbl_key(struct mt7615_dev *dev, int wcid, u8 cipher; cipher = mt7615_get_key_info(key, req.key.key_material); - if (cipher == MT_CIPHER_NONE && key) + if (cipher == MT_CIPHER_NONE) return -EOPNOTSUPP; req.key.rkv = 1;