From: Christopher Faulet <cfaulet@haproxy.com>
Date: Fri, 19 Apr 2024 13:29:57 +0000 (+0200)
Subject: BUG/MINOR: stconn: Fix sc_mux_strm() return value
X-Git-Tag: v3.0-dev8~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f58883002c6fd90b3bf8a70e779b7e72e76cec2c;p=thirdparty%2Fhaproxy.git

BUG/MINOR: stconn: Fix sc_mux_strm() return value

Since the begining, this function returns a pointer on an appctx while it
should be a void pointer. It is the caller responsibility to cast it to the
right type, the corresponding mux stream in this case.

However, it is not a big deal because this function is unused for now. Only
the unsafe one is used.

This patch must be backported as far as 2.6.
---

diff --git a/include/haproxy/stconn.h b/include/haproxy/stconn.h
index 2582ba38d7..c28edc2c39 100644
--- a/include/haproxy/stconn.h
+++ b/include/haproxy/stconn.h
@@ -255,7 +255,7 @@ static inline void *__sc_mux_strm(const struct stconn *sc)
 {
 	return __sc_endp(sc);
 }
-static inline struct appctx *sc_mux_strm(const struct stconn *sc)
+static inline void *sc_mux_strm(const struct stconn *sc)
 {
 	if (sc_ep_test(sc, SE_FL_T_MUX))
 		return __sc_mux_strm(sc);