From: Amos Jeffries <yadij@users.noreply.github.com>
Date: Tue, 6 Aug 2024 23:17:16 +0000 (+0000)
Subject: Maintenance: Replace one self_destruct() with throw (#1871)
X-Git-Tag: SQUID_7_0_1~83
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f5d4fc4f3caa293baae0fec138c1031bc4808774;p=thirdparty%2Fsquid.git

Maintenance: Replace one self_destruct() with throw (#1871)
---

diff --git a/src/acl/Acl.cc b/src/acl/Acl.cc
index 2d07d3fc9a..d48b5c0813 100644
--- a/src/acl/Acl.cc
+++ b/src/acl/Acl.cc
@@ -61,11 +61,8 @@ Acl::Node *
 Make(TypeName typeName)
 {
     const auto pos = TheMakers().find(typeName);
-    if (pos == TheMakers().end()) {
-        debugs(28, DBG_CRITICAL, "FATAL: Invalid ACL type '" << typeName << "'");
-        self_destruct();
-        assert(false); // not reached
-    }
+    if (pos == TheMakers().end())
+        throw TextException(ToSBuf("invalid ACL type '", typeName, "'"), Here());
 
     auto *result = (pos->second)(pos->first);
     debugs(28, 4, typeName << '=' << result);