From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 25 Jan 2022 07:51:26 +0000 (+0100)
Subject: qemuDomainAttachHostPCIDevice: Handle hostevs with unassigned type of address
X-Git-Tag: v8.1.0-rc1~269
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f5de3af7f46a8517794a186885e54eed84fb76d6;p=thirdparty%2Flibvirt.git

qemuDomainAttachHostPCIDevice: Handle hostevs with unassigned type of address

A <hostdev/> can have <address type='unassigned'/> which means
libvirt manages the device detach from/reattach to the host but
the device is never exposed to the guest. This means that we have
to take a shortcut during hotplug, similar to the one we are
taking when constructing the command line (see
qemuBuildHostdevCommandLine()).

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2040548
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 6e3a60b225..c0c3a8ec9f 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1668,6 +1668,12 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver,
         qemuDomainFillDeviceIsolationGroup(vm->def, &dev);
     }
 
+    if (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED) {
+        /* Unassigned devices are not exposed to QEMU. Our job is done here. */
+        ret = 0;
+        goto done;
+    }
+
     if (qemuDomainEnsurePCIAddress(vm, &dev) < 0)
         goto error;
     releaseaddr = true;
@@ -1692,6 +1698,7 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver,
  exit_monitor:
     qemuDomainObjExitMonitor(driver, vm);
 
+ done:
     virDomainAuditHostdev(vm, hostdev, "attach", ret == 0);
     if (ret < 0)
         goto error;