From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: Tue, 1 Sep 2020 10:40:42 +0000 (+0200)
Subject: hw/ppc/ppc4xx_pci: Replace pointless warning by assert()
X-Git-Tag: v5.2.0-rc0~127^2~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f5f239315cbf047aef51022ecb083fc7662c660a;p=thirdparty%2Fqemu.git

hw/ppc/ppc4xx_pci: Replace pointless warning by assert()

We call pci_register_root_bus() to register 4 IRQs with the
ppc4xx_pci_set_irq() handler. As it can only be called with
values in the [0-4[ range, replace the pointless warning by
an assert().

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200901104043.91383-5-f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---

diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c
index cd3f192a138..503ef46b39a 100644
--- a/hw/ppc/ppc4xx_pci.c
+++ b/hw/ppc/ppc4xx_pci.c
@@ -256,10 +256,7 @@ static void ppc4xx_pci_set_irq(void *opaque, int irq_num, int level)
     qemu_irq *pci_irqs = opaque;
 
     trace_ppc4xx_pci_set_irq(irq_num);
-    if (irq_num < 0) {
-        fprintf(stderr, "%s: PCI irq %d\n", __func__, irq_num);
-        return;
-    }
+    assert(irq_num >= 0);
     qemu_set_irq(pci_irqs[irq_num], level);
 }