From: Paul Eggert Date: Wed, 21 Aug 2019 16:29:09 +0000 (-0700) Subject: Remove dead regex code X-Git-Tag: changelog-ends-here~112 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f615e3fced100914b1ee4d690f380deb69a4be70;p=thirdparty%2Fglibc.git Remove dead regex code * posix/regex_internal.c (re_node_set_insert): Remove unnecessary assignment. Reported by Tim Rühsen in: https://lists.gnu.org/r/bug-gnulib/2019-08/msg00026.html --- diff --git a/ChangeLog b/ChangeLog index 2db09d2f188..182aa133535 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2019-08-21 Paul Eggert + Remove dead regex code + * posix/regex_internal.c (re_node_set_insert): + Remove unnecessary assignment. Reported by Tim Rühsen in: + https://lists.gnu.org/r/bug-gnulib/2019-08/msg00026.html + Fix bad pointer / leak in regex code This was found by Coverity (CID 1484201). [BZ#24844] * posix/regex_internal.c (create_cd_newstate): Fix use of bad diff --git a/posix/regex_internal.c b/posix/regex_internal.c index f53ded93a8f..99fbb26ecba 100644 --- a/posix/regex_internal.c +++ b/posix/regex_internal.c @@ -1311,7 +1311,6 @@ re_node_set_insert (re_node_set *set, Idx elem) first element separately to skip a check in the inner loop. */ if (elem < set->elems[0]) { - idx = 0; for (idx = set->nelem; idx > 0; idx--) set->elems[idx] = set->elems[idx - 1]; }