From: Joseph Myers <joseph@codesourcery.com>
Date: Wed, 27 Feb 2019 13:58:56 +0000 (+0000)
Subject: Fix -Wempty-body warnings in Hurd-specific code.
X-Git-Tag: glibc-2.30~320
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f627dd4da804c00b5e89e5e2c488c2bad6205262;p=thirdparty%2Fglibc.git

Fix -Wempty-body warnings in Hurd-specific code.

This patch fixes -Wempty-body warnings in Hurd-specific code that show
up building glibc with -Wextra.

Note: there also such warnings on many platforms arising from the
default definition of HP_TIMING_NOW in sysdeps/generic/hp-timing.h,
but no change there is proposed in this patch because of other changes
under discussion in that area that would result in a nonempty
definition.

Tested with build-many-glibcs.py.

	* hurd/hurdinit.c (_hurd_init): Use braces around empty body of an
	if statement.
---

diff --git a/ChangeLog b/ChangeLog
index 34e4558bb5e..de34cdd0056 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2019-02-27  Joseph Myers  <joseph@codesourcery.com>
 
+	* hurd/hurdinit.c (_hurd_init): Use braces around empty body of an
+	if statement.
+
 	* benchtests/bench-strcpy.c (do_test): Use space before '('.
 	* benchtests/bench-string.h (cmdline_process_function): Likewise.
 	* benchtests/bench-strlen.c (do_test): Likewise.
diff --git a/hurd/hurdinit.c b/hurd/hurdinit.c
index f4a3607ae67..938e6da5e38 100644
--- a/hurd/hurdinit.c
+++ b/hurd/hurdinit.c
@@ -100,10 +100,12 @@ _hurd_init (int flags, char **argv,
 		   portarraysize * sizeof (mach_port_t));
 
   if (flags & EXEC_SECURE)
-    /* XXX if secure exec, elide environment variables
-       which the library uses and could be security holes.
-       CORESERVER, COREFILE
-       */ ;
+    {
+      /* XXX if secure exec, elide environment variables
+	 which the library uses and could be security holes.
+	 CORESERVER, COREFILE
+      */
+    }
 
   /* Call other things which want to do some initialization.  These are not
      on the __libc_subinit hook because things there like to be able to