From: Paolo Bonzini <pbonzini@redhat.com>
Date: Fri, 17 Jun 2016 15:01:21 +0000 (+0200)
Subject: ich9: call ich9_lpc_update_pic for disabled pirqs
X-Git-Tag: v2.7.0-rc0~75^2~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f62efcacfab114d0fae016dd9c0cd500f70dd70d;p=thirdparty%2Fqemu.git

ich9: call ich9_lpc_update_pic for disabled pirqs

An asserted pirq can be disabled and the corresponding GSIs
should then go down to 0.  However, because of the conditional in
ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1.

Reviewed-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
index c1a4f1b34c1..f7aed231e64 100644
--- a/hw/isa/lpc_ich9.c
+++ b/hw/isa/lpc_ich9.c
@@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq)
 
     ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis);
     assert(pic_irq < ICH9_LPC_PIC_NUM_PINS);
-    if (pic_dis) {
-        return;
-    }
 
     ich9_lpc_update_pic(lpc, pic_irq);
 }