From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 16 Oct 2021 09:39:21 +0000 (+0200)
Subject: refs API: make refs_resolve_refdup() not set errno
X-Git-Tag: v2.35.0-rc0~135^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f65bb9fb06f969e8fb89de2d6dc9218f13cb361c;p=thirdparty%2Fgit.git

refs API: make refs_resolve_refdup() not set errno

Move refs_resolve_refdup() from the legacy refs_resolve_ref_unsafe()
to the new refs_werrres_ref_unsafe(). I have read its callers and
determined that they don't care about errno being set.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/refs.c b/refs.c
index dc6ed56149..09452b5e41 100644
--- a/refs.c
+++ b/refs.c
@@ -268,9 +268,10 @@ char *refs_resolve_refdup(struct ref_store *refs,
 			  struct object_id *oid, int *flags)
 {
 	const char *result;
+	int ignore_errno;
 
-	result = refs_resolve_ref_unsafe(refs, refname, resolve_flags,
-					 oid, flags);
+	result = refs_werrres_ref_unsafe(refs, refname, resolve_flags,
+					 oid, flags, &ignore_errno);
 	return xstrdup_or_null(result);
 }