From: Marc Kleine-Budde Date: Tue, 6 May 2025 13:55:19 +0000 (+0200) Subject: Merge patch series "can: rx-offload: fix order of unregistration calls" X-Git-Tag: v6.15-rc6~26^2~10^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f695e3083afe7db94d4e65a55be29e523280e4d7;p=thirdparty%2Flinux.git Merge patch series "can: rx-offload: fix order of unregistration calls" Marc Kleine-Budde says: If a driver is removed, the driver framework invokes the driver's remove callback. A CAN driver's remove function calls unregister_candev(), which calls net_device_ops::ndo_stop further down in the call stack for interfaces which are in the "up" state. With the mcp251xfd driver the removal of the module causes the following warning: | WARNING: CPU: 0 PID: 352 at net/core/dev.c:7342 __netif_napi_del_locked+0xc8/0xd8 as can_rx_offload_del() deletes the NAPI, while it is still active, because the interface is still up. To fix the warning, first unregister the network interface, which calls net_device_ops::ndo_stop, which disables the NAPI, and then call can_rx_offload_del(). All other driver using the rx-offload helper have been checked and the same issue has been found in the rockchip and m_can driver. These have been fixed, but only compile time tested. On the mcp251xfd the fix was tested on hardware. Link: https://patch.msgid.link/20250502-can-rx-offload-del-v1-0-59a9b131589d@pengutronix.de Signed-off-by: Marc Kleine-Budde --- f695e3083afe7db94d4e65a55be29e523280e4d7