From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Wed, 19 Jul 2023 00:55:15 +0000 (+1200)
Subject: nsswitch:libwbclient: Fix memory leak
X-Git-Tag: tevent-0.16.0~1175
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f6babaa9b6618201c9915c1992d0f3926c02c6bd;p=thirdparty%2Fsamba.git

nsswitch:libwbclient: Fix memory leak

Found by Balazs Scheidler <bazsi@balabit.hu>.

Reported by Ferenc Wágner <wferi@niif.hu> at
https://lists.samba.org/archive/samba-technical/2023-June/138271.html

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/nsswitch/libwbclient/wbc_pam.c b/nsswitch/libwbclient/wbc_pam.c
index aed9c05fa71..786d578478e 100644
--- a/nsswitch/libwbclient/wbc_pam.c
+++ b/nsswitch/libwbclient/wbc_pam.c
@@ -418,6 +418,7 @@ wbcErr wbcCtxAuthenticateUserEx(struct wbcContext *ctx,
 				 params->domain_name,
 				 sep_response.data.info.winbind_separator,
 				 params->account_name);
+			winbindd_free_response(&sep_response);
 		} else {
 			strncpy(request.data.auth.user,
 				params->account_name,